Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix missing array clone when building table filter for mv index access path (#52613) #52621

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52613

What problem does this PR solve?

Issue Number: close #52609

Problem Summary:

The slices.Delete() below will unexpectedly modify the input allConds.

What changed and how does it work?

Use slices.Clone() to make sure a new array is allocated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@97385ec). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52621   +/-   ##
================================================
  Coverage               ?   72.2835%           
================================================
  Files                  ?       1467           
  Lines                  ?     426880           
  Branches               ?          0           
================================================
  Hits                   ?     308564           
  Misses                 ?      99018           
  Partials               ?      19298           
Flag Coverage Δ
unit 71.1523% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0929% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-15 15:44:05.116023015 +0000 UTC m=+266464.227069467: ☑️ agreed by AilinKid.
  • 2024-04-15 15:58:05.415763387 +0000 UTC m=+267304.526809836: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit b2920b4 into pingcap:release-8.1 Apr 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants