Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix the missing type of query total counter for resource groups above 2 (#52606) #52638

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52606

What problem does this PR solve?

Issue Number: close #52605

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…ps above 2

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 16, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 16, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 16, 2024
@nolouch nolouch requested a review from glorv April 16, 2024 07:27
Copy link

ti-chi-bot bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-16 07:27:24.389871432 +0000 UTC m=+323063.500917884: ☑️ agreed by nolouch.
  • 2024-04-16 08:04:07.04619368 +0000 UTC m=+325266.157240130: ☑️ agreed by glorv.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@b2920b4). Click here to learn what that means.
The diff coverage is 30.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52638   +/-   ##
================================================
  Coverage               ?   72.3111%           
================================================
  Files                  ?       1467           
  Lines                  ?     427049           
  Branches               ?          0           
================================================
  Hits                   ?     308804           
  Misses                 ?      98976           
  Partials               ?      19269           
Flag Coverage Δ
unit 71.1829% <30.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0929% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit ce8c310 into pingcap:release-8.1 Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants