Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: load auto id related changes for multi-schema-change diff | tidb-test=pr/2320 #52967

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #47899

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

for the case in the issue

mysql>  create table t (a int not null auto_increment primary key, b int) auto_id_cache 100;insert into t (b) values (1);
Query OK, 0 rows affected (0.09 sec)

Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+---+------+
| a | b    |
+---+------+
| 1 |    1 |
+---+------+
1 row in set (0.00 sec)

mysql> alter table t add column c int, auto_increment 200;
Query OK, 0 rows affected (0.31 sec)

mysql> insert into t (b) values (2);
Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+-----+------+------+
| a   | b    | c    |
+-----+------+------+
|   1 |    1 | NULL |
| 200 |    2 | NULL |
+-----+------+------+
2 rows in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2024
Copy link

tiprow bot commented Apr 29, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

select * from t;
a b
100 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no insert before alter table, so it works

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.6983%. Comparing base (66ba419) to head (569d50a).
Report is 20 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52967         +/-   ##
=================================================
- Coverage   72.3850%   55.6983%   -16.6867%     
=================================================
  Files          1482       1614        +132     
  Lines        428662     607084     +178422     
=================================================
+ Hits         310287     338136      +27849     
- Misses        99083     245795     +146712     
- Partials      19292      23153       +3861     
Flag Coverage Δ
integration 36.9884% <86.0465%> (?)
unit 71.2299% <74.4186%> (+0.0102%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.6570% <ø> (+5.5030%) ⬆️

@D3Hunter D3Hunter changed the title infoschema: load auto id related changes for multi-schema-change diff infoschema: load auto id related changes for multi-schema-change diff | tidb-test=pr/2320 Apr 29, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 29, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/check-issue-triage-complete

// if some step only contains one action, Type will be that action, and ActionTypes
// will be empty.
// for other types of job, it will always be empty.
ActionTypes []ActionType `json:"action_types"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using SubTypes instead of ActionTypes? Thus unified with the Type field and MultiSchemaInfo.SubJobs. Just a suggestion

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 02:50:23.9629025 +0000 UTC m=+325577.720038073: ☑️ agreed by tiancaiamao.
  • 2024-04-30 06:27:52.037006158 +0000 UTC m=+338625.794141731: ☑️ agreed by zimulala.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Apr 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/parser/model/ddl.go Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, tiancaiamao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 30, 2024
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot bot merged commit c24dca5 into pingcap:master Apr 30, 2024
21 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53008.

@D3Hunter D3Hunter deleted the fix-msc-autoid branch April 30, 2024 08:54
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53473.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@lance6716
Copy link
Contributor

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-6.5: #53735.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 3, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rebase auto_increment in multi object ALTER TABLE does not update the same TiDB node's cached auto id.
8 participants