Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/copr: fix tracing for copr.buildCopTasks #53086

Merged
merged 1 commit into from
May 8, 2024

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #53085

What changed and how does it work?

Simple change. Please see the issue and code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5661%. Comparing base (40c81c0) to head (3f9a568).
Report is 43 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53086        +/-   ##
================================================
+ Coverage   72.3860%   74.5661%   +2.1800%     
================================================
  Files          1482       1509        +27     
  Lines        428754     446153     +17399     
================================================
+ Hits         310358     332679     +22321     
+ Misses        99088      93405      -5683     
- Partials      19308      20069       +761     
Flag Coverage Δ
integration 49.8094% <100.0000%> (?)
unit 71.8233% <100.0000%> (+0.5979%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 43.9660% <ø> (+2.7986%) ⬆️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 11:50:01.290573706 +0000 UTC m=+962755.047709279: ☑️ agreed by tiancaiamao.
  • 2024-05-07 14:36:52.756937914 +0000 UTC m=+972766.514073487: ☑️ agreed by Defined2014.

@time-and-fate
Copy link
Member Author

time-and-fate commented May 7, 2024

/hold

wait to see if we need some other tweaks

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@time-and-fate
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9c5981c into pingcap:master May 8, 2024
20 of 21 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing code for copr.buildCopTasks is wrong
4 participants