-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix mppIterator memory leak when got error #53106
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Hi @guo-shaoge. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53106 +/- ##
================================================
+ Coverage 72.4152% 74.7272% +2.3119%
================================================
Files 1490 1491 +1
Lines 429038 430689 +1651
================================================
+ Hits 310689 321842 +11153
+ Misses 99071 88995 -10076
- Partials 19278 19852 +574
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Wait for integration test result |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-53106-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-53106-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
What problem does this PR solve?
Issue Number: close #52406
Problem Summary:
#52410 tried to fix this issue, but it didn't work, so fix again
What changed and how does it work?
Check List
Tests
Before:
After:
![img_v3_02an_d26a670e-be33-4a14-b97a-4860a99a893g](https://private-user-images.githubusercontent.com/7493273/329174528-773f4c94-9d9c-489f-8c49-7afdb8a7bd2e.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxODY3NzksIm5iZiI6MTcyMDE4NjQ3OSwicGF0aCI6Ii83NDkzMjczLzMyOTE3NDUyOC03NzNmNGM5NC05ZDljLTQ4OWYtOGM0OS03YWZkYjhhN2JkMmUuanBnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDVUMTMzNDM5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzY4ZmVhNWU0OGQ5YThiNzIwOGQxMDdjNmM5MGRkMDJiYWQ5NDk5ZTY5ZjFjMjk2YTg4NTk0YmM0YzU4YWFkOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.p93jNu7_rTr9uQ_YPEtrGKjNwaw7ZOCsIZ1mULZQFF8)
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.