executor: fix mppIterator memory leak when got error

[guo-shaoge]

What problem does this PR solve?

Issue Number: close #52406

Problem Summary: check issue for detail description

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @guo-shaoge. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #52410 (e487d8e) into master (c39d79f) will increase coverage by 0.3421%.
Report is 14 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52410        +/-   ##
================================================
+ Coverage   74.1210%   74.4632%   +0.3421%     
================================================
  Files          1467       1467                
  Lines        354273     429648     +75375     
================================================
+ Hits         262591     319930     +57339     
- Misses        72444      89794     +17350     
- Partials      19238      19924       +686     

Flag	Coverage Δ
integration	48.9601% <0.0000%> (?)
unit	71.0019% <0.0000%> (-1.8772%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	49.4395% <ø> (+7.0017%)	⬆️

[guo-shaoge]

/retest

[tiprow]

@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[windtalker]

How about move L511 after L499?

[guo-shaoge]

Golang lint will report error: pkg/executor/internal/mpp/local_mpp_coordinator.go:500:2: should check returned error before deferring stream.Close() (SA5001)

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-09 07:34:57.53266097 +0000 UTC m=+947759.060201509: ☑️ agreed by windtalker.
• 2024-04-09 07:59:08.864357927 +0000 UTC m=+949210.391898473: ☑️ agreed by SeaRise.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #53105.