-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta,ddl: fix duplicate entry error when insert after drop and recover table (#52761) #53187
meta,ddl: fix duplicate entry error when insert after drop and recover table (#52761) #53187
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53187 +/- ##
================================================
Coverage ? 71.6533%
================================================
Files ? 1465
Lines ? 424949
Branches ? 0
================================================
Hits ? 304490
Misses ? 100118
Partials ? 20341
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, D3Hunter, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #52761
What problem does this PR solve?
Issue Number: close #52680
Problem Summary:
What changed and how does it work?
After #39041,
CreateTableAndSetAutoID
do not set the auto id correctly.We should recover RowID, AutoIncrementID, RandomID..
P.S. drop table do not remove auto id entry in autoid service, this is not a problem.
Check List
Tests
Follow the steps described in the issue.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.