Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: add ballast mem to reduce the runtime overhead during execution (#53407) #53429

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53407

What problem does this PR solve?

Issue Number: ref #52887, #51852

Problem Summary:

What changed and how does it work?

Add a ballast memory in coprocessor, this can reduce the morestack call during coprocessor worker execution, lower the latency.

This is not the final solution for the referenced issues, it's just a hotfix, we need to manage the goroutine better to achieve both latency and throughput.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Test with sysbench

workload nightly this pr diff
select_random_points 19714 qps 20599 qps +4.5%
select_random_ranges 18754 qps 19207 qps +2.4%

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

you06 added 2 commits May 21, 2024 02:57
Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

comment

Signed-off-by: you06 <you1474600@gmail.com>

only allocate ballast when task received

Signed-off-by: you06 <you1474600@gmail.com>

set 32kb ballast

Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 21, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
Copy link

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 03:08:16.723492259 +0000 UTC m=+2141050.480627832: ☑️ agreed by hawkingrei.
  • 2024-05-21 03:23:08.765847191 +0000 UTC m=+2141942.522982764: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 21, 2024
@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented May 21, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@9e5c591). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53429   +/-   ##
================================================
  Coverage               ?   71.1542%           
================================================
  Files                  ?       1465           
  Lines                  ?     421431           
  Branches               ?          0           
================================================
  Hits                   ?     299866           
  Misses                 ?     101081           
  Partials               ?      20484           
Flag Coverage Δ
unit 71.1542% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9873% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 945d07c into pingcap:release-8.1 May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants