Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix mpp final agg couldn't co-exist with other non-final mode (#53455) #53476

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53455

What problem does this PR solve?

Issue Number: close #51362

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix mpp final agg couldn't co-exist with non-final mode

Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 22, 2024
@AilinKid
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Jul 16, 2024

@AilinKid: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 08:48:30.121685053 +0000 UTC m=+343732.112626530: ☑️ agreed by AilinKid.
  • 2024-07-16 08:51:30.434726508 +0000 UTC m=+343912.425667978: ☑️ agreed by XuHuaiyu.

@AilinKid
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Jul 16, 2024

@AilinKid: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@945d07c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53476   +/-   ##
================================================
  Coverage               ?   71.8015%           
================================================
  Files                  ?       1465           
  Lines                  ?     428498           
  Branches               ?          0           
================================================
  Hits                   ?     307668           
  Misses                 ?     100445           
  Partials               ?      20385           
Flag Coverage Δ
unit 71.8015% <92.6829%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.7434% <0.0000%> (?)

@AilinKid
Copy link
Contributor

/rebuild

@winoros
Copy link
Member

winoros commented Jul 31, 2024

/retest

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Aug 1, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 20acb79 into pingcap:release-8.1 Aug 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants