ddl: query since min job id to mitigate slowness due to un-compacted deleted kv

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #53246

Problem Summary:

What changed and how does it work?

• query since min job id to mitigate slowness due to un-compacted deleted kv, see this issue select very slow on an empty table from delete from xx #52905. by query since min job id, tikv can directly seek to the starting KV and skip all those that have deleted but not compacted without scanning

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

after #54003 we have optimized create 100K tables under same database on owner node on 1pd/3tidb/3tikv using 10 threads from 50m -> 38m33, as we have reduced the number of query for each job from 2 to 1

after this pr, on same env, it takes 34m58

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 65.67164% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.2394%. Comparing base (d0e775d) to head (648db72).
Report is 7 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54122         +/-   ##
=================================================
- Coverage   74.8008%   56.2394%   -18.5615%     
=================================================
  Files          1516       1639        +123     
  Lines        360897     607115     +246218     
=================================================
+ Hits         269954     341438      +71484     
- Misses        71336     242373     +171037     
- Partials      19607      23304       +3697     

Flag	Coverage Δ
integration	37.2240% <90.6250%> (?)
unit	71.9778% <65.6716%> (-1.7086%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-2.2339%)	⬇️
parser	∅ <ø> (∅)
br	52.6966% <ø> (+4.7265%)	⬆️

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

@lance6716 it seems most speedup comes from remove the sub-query inside getJobSQL which i have reverted in this pr as it handles "fair lock" which is changed in your pr #54110. remove this sub-query requires us handle fair across job type, i will file another pr to remove this sub-query

i have update the test result in desc, it's 38m33 -> 34m58 now.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance6716,tangenta]
• pkg/ddl/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-20 06:22:37.224787254 +0000 UTC m=+268683.710276088: ☑️ agreed by lance6716.
• 2024-06-20 07:02:56.525501806 +0000 UTC m=+271103.010990638: ☑️ agreed by tangenta.

[D3Hunter]

/retest

there is a flaky TestParallelFlashbackTable case, will check it later, #54134, retest first

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

there is a flaky TestParallelFlashbackTable case, will check it later, retest first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.