session, executor, domain: use the SQL start time to calculate the runaway deadline #54496
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot
bot
added
release-note-none
|
/cc @nolouch @hi-rustin PTAL. |
| @@ -476,7 +476,7 @@ type RunawayChecker struct { | |||
| watchAction rmpb.RunawayAction | |||
| } | |||
|
|
|||
| func newRunawayChecker(manager *RunawayManager, resourceGroupName string, setting *rmpb.RunawaySettings, originalSQL, sqlDigest, planDigest string) *RunawayChecker { | |||
| func newRunawayChecker(manager *RunawayManager, resourceGroupName string, setting *rmpb.RunawaySettings, originalSQL, sqlDigest, planDigest string, startTime time.Time) *RunawayChecker { | |||
There was a problem hiding this comment.
seems some params passed from sessionVars, maybe directly pass the sessVars in here?
There was a problem hiding this comment.
After testing, it appears that moving GetPlanDigest causes an import cycle. Therefore, I suggest we keep it as is for now.
|
/approve |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54496 +/- ##
=================================================
- Coverage 74.7636% 56.0020% -18.7616%
=================================================
Files 1542 1663 +121
Lines 362006 608281 +246275
=================================================
+ Hits 270649 340650 +70001
- Misses 71710 244269 +172559
- Partials 19647 23362 +3715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@JmPotato: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, hi-rustin, lance6716, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/test unit-test |
|
@JmPotato: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #54434.
What changed and how does it work?
Use the
StartTimeinSessionVarsto calculate the runaway deadline.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.