-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv, metrics: record detail rpc type and store id. #5461
Conversation
store/tikv/tikvrpc/tikvrpc.go
Outdated
case CmdCop: | ||
return "cop" | ||
case CmdCopStream: | ||
return "scpStream" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copStream
store/tikv/tikvrpc/tikvrpc.go
Outdated
func (t CmdType) String() string { | ||
switch t { | ||
case CmdGet: | ||
return "get" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use upper case for the first char may be better?
store/tikv/metrics.go
Outdated
@@ -85,7 +85,7 @@ var ( | |||
Name: "request_seconds", | |||
Help: "Bucketed histogram of sending request duration.", | |||
Buckets: prometheus.ExponentialBuckets(0.0005, 2, 18), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should use a larger bucket, expand to 20?
Rest LGTM |
Done. @siddontang |
LGTM |
/run-all-tests |
LGTM |
No description provided.