metrics: Clean up metrics #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Feb 11, 2018
metrics/ddl.go
Outdated
| WorkerWaitSchemaChanged = "wait_schema_changed" | ||
| DDLWorkerHistogram = prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Namespace: "tidb", | ||
| Subsystem: "ddl", | ||
| Name: "ddl_worker_operation", | ||
| Name: "worker_operation", |
There was a problem hiding this comment.
worker_operation_duration is better.
coocood
reviewed
Feb 11, 2018
metrics/meta.go
Outdated
| @@ -20,8 +20,8 @@ import ( | |||
| // Metrics | |||
| var ( | |||
| GlobalAutoID = "global" | |||
| TableAutoIDAlloc = "table" | |||
| TableAutoIDRebase = "table_rebase" | |||
| TableAutoIDAlloc = "id_alloc" | |||
There was a problem hiding this comment.
How about just alloc and rebase?
And the subsystem name change to autoid?
|
@coocood PTAL |
|
/run-all-tests |
|
LGTM |
coocood
approved these changes
Feb 11, 2018
tiancaiamao
reviewed
Feb 11, 2018
| @@ -32,11 +32,11 @@ const ( | |||
| LabelDDL = "ddl" | |||
| LabelGCWorker = "gcworker" | |||
|
|
|||
| opSucc = "op_succ" | |||
There was a problem hiding this comment.
Remind: this may also involves some changes in prometheus dashboard~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make metrics content more clear and compact.