Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix "insert into t1 (select * from t)" #6039

Merged
merged 3 commits into from
Mar 13, 2018
Merged

parser: fix "insert into t1 (select * from t)" #6039

merged 3 commits into from
Mar 13, 2018

Conversation

tiancaiamao
Copy link
Contributor

we support

insert into t1 select * from t

but not

insert into t1 (select * from t)

This is a fix for issue #6038

@tiancaiamao
parser: fix "insert into t1 (select * from t)"
41fd666 
we support
insert into t1 select * from t
but not
insert into t1 (select * from t)

This commit is a fix
@shenli
Copy link
Member

shenli commented Mar 13, 2018

LGTM

@shenli shenli added status/LGT1 Indicates that a PR has LGTM 1. type/compatibility labels Mar 13, 2018
zz-jason
zz-jason previously approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2018
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-integration-common-test

@jackysp jackysp merged commit 2b81622 into pingcap:master Mar 13, 2018
@tiancaiamao tiancaiamao deleted the fix-6038 branch March 13, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @shenli @zz-jason @XuHuaiyu @jackysp