Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix a bug when applying top-n push down rule. #6187

Merged
merged 5 commits into from
Mar 30, 2018

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 29, 2018

If the limit operator is combined with a sort operator, it's a new operator and should not be eliminated.

@shenli
Copy link
Member

shenli commented Mar 29, 2018

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Mar 30, 2018

@lamxTyler @zz-jason PTAL

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 30, 2018
@zz-jason zz-jason merged commit e080c37 into pingcap:master Mar 30, 2018
@winoros winoros deleted the top-n-bug branch March 30, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants