-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Refine error message about "Out of range value for column" #6334
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
well done. |
/add-to-whitelist |
/run-all-tests |
@spongedu OK, I'll handle this. |
4849cee
to
8f00699
Compare
caa3708
to
6694c12
Compare
types/errors.go
Outdated
@@ -73,6 +76,8 @@ const ( | |||
codeUnknown = terror.ErrCode(mysql.ErrUnknown) | |||
codeInvalidDefault = terror.ErrCode(mysql.ErrInvalidDefault) | |||
codeMBiggerThanD = terror.ErrCode(mysql.ErrMBiggerThanD) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this empty line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests tidb-test=pr/512 |
/run-all-tests |
LGTM |
/run-all-tests tidb-test=pr/512 |
@zz-jason We need to update the integration test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
%ld
,%u