plan, parser: support JOIN hint for UPDATE/DELETE statements #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lzmhhh123 Please add some description for this PR. |
|
/run-all-tests |
zz-jason
reviewed
May 23, 2018
parser/parser.y
Outdated
| x.Where = $8.(ast.ExprNode) | ||
| Priority: $3.(mysql.PriorityEnum), | ||
| Quick: $4.(bool), | ||
| IgnoreErr: $5.(bool), |
There was a problem hiding this comment.
plz fix the code indent before $5.(bool),
ast/dml.go
Outdated
| @@ -791,6 +791,8 @@ type DeleteStmt struct { | |||
| Quick bool | |||
| IsMultiTable bool | |||
| BeforeFrom bool | |||
| // TableHints represents the level Optimizer Hint | |||
alivxxx
reviewed
May 24, 2018
| @@ -1998,60 +1998,67 @@ DoStmt: | |||
| * | |||
| *******************************************************************/ | |||
| DeleteFromStmt: | |||
| "DELETE" PriorityOpt QuickOptional IgnoreOptional "FROM" TableName IndexHintListOpt WhereClauseOptional OrderByOptional LimitClause | |||
| "DELETE" TableOptimizerHints PriorityOpt QuickOptional IgnoreOptional "FROM" TableName IndexHintListOpt WhereClauseOptional OrderByOptional LimitClause | |||
There was a problem hiding this comment.
Seem that the TableOptimizerHints is not used?
There was a problem hiding this comment.
Yeah, but it will cause yacc reduce conflict without this TableOptimizerHints.
|
/run-all-tests |
zz-jason
reviewed
May 24, 2018
ast/dml.go
Outdated
| @@ -791,6 +791,8 @@ type DeleteStmt struct { | |||
| Quick bool | |||
| IsMultiTable bool | |||
| BeforeFrom bool | |||
| // TableHints represents the level Optimizer Hint for join type. | |||
There was a problem hiding this comment.
Do you mean "the table level optimizer hint"?
There was a problem hiding this comment.
Yeah. I just referred the previous comments.
There was a problem hiding this comment.
How about fixing these wrong comments in this PR?
… into dev/joinhintenhance
|
LGTM |
|
@winoros @lamxTyler PTAL |
|
LGTM |
shenli
added
status/LGT2
shenli
approved these changes
May 25, 2018
coocood
pushed a commit
to coocood/tidb
that referenced
this pull request
May 31, 2018
coocood
added a commit
that referenced
this pull request
May 31, 2018
* support high priority for DELETE/UPDATE statement * plan, parser: support JOIN hint for UPDATE/DELETE statements (#6626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support JOIN hints like
/*+ TiDB_SMJ */inUPDATE&DELETEstatements.