Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: skip inner rows when the join keys contains NULL (#7255) #7301

Merged
merged 1 commit into from Aug 8, 2018

Conversation

@zz-jason
Copy link
Member

commented Aug 7, 2018

What have you changed? (mandatory)

cherry-pick #7255 to release-2.0

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

  • existing test
  • newly add UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

An example:

release note:
Fix the wrong behavior of `Merge Join` and `Index Join` in a special scenario.
@winoros
winoros approved these changes Aug 7, 2018
Copy link
Member

left a comment

lgtm

@coocood
coocood approved these changes Aug 8, 2018
Copy link
Member

left a comment

LGTM

@coocood

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@zz-jason zz-jason merged commit 478d990 into pingcap:release-2.0 Aug 8, 2018
11 checks passed
11 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zz-jason zz-jason deleted the zz-jason:cherry-pick/7255 branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.