Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refactor `joinResultGenerator` to handle the unmatched outer records (#7288) #7315

Merged
merged 2 commits into from Aug 8, 2018

Conversation

Projects
None yet
3 participants
@zz-jason
Copy link
Member

commented Aug 8, 2018

What have you changed? (mandatory)

cherrypick #7288 to release-2.0

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

  • existing tests
  • newly added tests

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

release note:
Fix a bug that the `Outer Join` may output the same unmatched outer records multiply times under certain special conditions.
@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2018

@zhexuany
Copy link
Member

left a comment

LGTM

@winoros

winoros approved these changes Aug 8, 2018

Copy link
Member

left a comment

lgtm

@zz-jason zz-jason merged commit 343ed54 into pingcap:release-2.0 Aug 8, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:cherrypick/7288 branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.