Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle max_allowed_packet warnings for from_base64 function. #7430

Merged
merged 2 commits into from
Aug 18, 2018

Conversation

supernan1994
Copy link
Contributor

What problem does this PR solve?

cherrypick #7409 (from commit 4624785) to release-2.0

What is changed and how it works?

Return NULL and a warning when the result of from_base64 exceeds max_allowed_packetbs.

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note
release note:
handle `max_allowed_packet` warnings for `FROM_BASE64` function

@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@supernan1994
Copy link
Contributor Author

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@zz-jason
Copy link
Member

LGTM

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Aug 18, 2018

@supernan1994 Thanks!

@shenli shenli merged commit 143b525 into pingcap:release-2.0 Aug 18, 2018
@supernan1994
Copy link
Contributor Author

@shenli My pleasure~

@supernan1994 supernan1994 deleted the cherrypick/7409 branch August 18, 2018 15:56
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants