tables: Remove index data in table.Truncate() #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _, err = ts.se.Execute("drop table test.t") | ||
| c.Assert(err, IsNil) | ||
| } | ||
|
|
||
| func countEntriesWithPrefix(ctx context.Context, prefix string) (int, error) { |
There was a problem hiding this comment.
Could you use ScanMetaWithPrefix function to do the job ?
There was a problem hiding this comment.
Yes, it is better now. PTAL
Address comment
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 8, 2015
tables: Remove index data in table.Truncate()
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
…ap#76) Previously when these steps failed the errors will not be reflected from the error code and the process will just continue.
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 30, 2024
…) (pingcap#52360) (pingcap#76) close pingcap#52175 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug