Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, expression: calculating the default value for datetime should consider the time zone (#7655) #7672

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

cherry pick #7655 to release-2.0

What is changed and how it works?

Check List

Tests

  • Unit test

@zz-jason
Copy link
Member Author

@jackysp PTAL

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Sep 11, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0 pd=release-2.0

@zz-jason zz-jason added type/bugfix This PR fixes a bug. component/expression type/2.0 cherry-pick status/LGT2 Indicates that a PR has LGTM 2. labels Sep 11, 2018
@zz-jason
Copy link
Member Author

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

1 similar comment
@zhexuany
Copy link
Contributor

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Sep 17, 2018

/run-common-test tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

@lysu
Copy link
Contributor

lysu commented Sep 17, 2018

/run-common-test tikv=release-2.0 pd=release-2.0 tidb-test=pr/624
/run-integration-common-test tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

@lysu
Copy link
Contributor

lysu commented Sep 20, 2018

/run-common-test tidb-private-test=release-2.0 tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

@coocood
Copy link
Member

coocood commented Sep 20, 2018

/run-common-test tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

1 similar comment
@coocood
Copy link
Member

coocood commented Sep 20, 2018

/run-common-test tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

@coocood coocood merged commit 2f1d8ec into pingcap:release-2.0 Sep 20, 2018
@iamxy
Copy link
Member

iamxy commented Sep 20, 2018

/run-common-test tidb-private-test=release-2.0 tikv=release-2.0 pd=release-2.0 tidb-test=pr/624

@zz-jason zz-jason deleted the cherrypick/datetime branch October 22, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants