executor,sessionctx:Add correctness for system variable: sync_binlog,… #7716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
|
… innodb_commit_concurrency, innodb_fast_shutdown, innodb_lock_wait_timeout.
FateTHarlaown
force-pushed
the
myfeature
branch
from
d365431
to
0e90dee
Compare
|
@FateTHarlaown Thanks! |
|
/run-all-tests |
alivxxx
reviewed
Sep 17, 2018
sessionctx/variable/sysvar.go
Outdated
| @@ -713,6 +713,12 @@ const ( | |||
| DelayKeyWrite = "delay_key_write" | |||
| // EndMakersInJSON is the name for 'end_markers_in_json' system variable. | |||
| EndMakersInJSON = "end_markers_in_json" | |||
| //InnodbCommitConcurrency is the name for 'innodb_commit_concurrency' system variable. | |||
There was a problem hiding this comment.
It is better to add a space between // and comment.
|
/run-all-tests |
shenli
added
status/LGT1
shenli
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
for #7195
Add correctness for system variable: sync_binlog, innodb_commit_concurrency, innodb_fast_shutdown, innodb_lock_wait_timeout.
What is changed and how it works?
changed executor, sessionctx
use the framework added in #7117
Check List
Tests
Unit test
Code changes
Side effects
Related changes