Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix "values" function in non-insert statement #8019

Merged
merged 8 commits into from Nov 5, 2018
Merged

expression: fix "values" function in non-insert statement #8019

merged 8 commits into from Nov 5, 2018

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

The document for the "values" function in MySQL 5.7, https://dev.mysql.com/doc/refman/5.7/en/miscellaneous-functions.html#function_values:

The VALUES() function is meaningful only in the ON DUPLICATE KEY UPDATE clause of INSERT statements and returns NULL otherwise

What is changed and how it works?

return NULL for non-insert statements

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@zz-jason
Copy link
Member Author

@XuHuaiyu @eurekaka PTAL

@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

zz-jason commented Nov 2, 2018

/run-all-tests

@zz-jason
Copy link
Member Author

zz-jason commented Nov 2, 2018

/run-all-tests

@zz-jason
Copy link
Member Author

zz-jason commented Nov 2, 2018

/run-unit-test

eurekaka
eurekaka reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2018
alivxxx
alivxxx approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2018
@XuHuaiyu XuHuaiyu merged commit 6efbd17 into pingcap:master Nov 5, 2018
zz-jason added a commit to zz-jason/tidb that referenced this pull request Nov 5, 2018
@zz-jason
expression: fix "values" function in non-insert statement (pingcap#8019)
1ec2294
@zz-jason zz-jason mentioned this pull request Nov 5, 2018
Merged
zz-jason added a commit that referenced this pull request Nov 5, 2018
@zz-jason
expression: fix "values" function in non-insert statement (#8019) (#8169
3be9756 
)
zz-jason added a commit to zz-jason/tidb that referenced this pull request Nov 5, 2018
@zz-jason
expression: fix "values" function in non-insert statement (pingcap#8019)
2e0c135
@zz-jason zz-jason mentioned this pull request Nov 5, 2018
Merged
zz-jason added a commit that referenced this pull request Nov 5, 2018
@zz-jason
expression: fix "values" function in non-insert statement (#8019) (#8179
ff434b3 
)
@zz-jason zz-jason deleted the bugfix/values-in-non-insert branch November 6, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zz-jason @eurekaka @XuHuaiyu @alivxxx @ngaut