Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix "values" function in non-insert statement (#8019) #8169

Merged
merged 1 commit into from Nov 5, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Nov 5, 2018

cherrypick #8019 to release 2.1

@zz-jason
Copy link
Member Author

zz-jason commented Nov 5, 2018

@XuHuaiyu @winoros PTAL

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Nov 5, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@zz-jason
Copy link
Member Author

zz-jason commented Nov 5, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 3be9756 into pingcap:release-2.1 Nov 5, 2018
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 5, 2018
@zz-jason zz-jason deleted the cherrypick/expr-values branch November 5, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants