store/tikv: Make maxTxnTimeUse a configurable value #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
LGTM |
zz-jason
reviewed
Nov 7, 2018
store/tikv/2pc.go
Outdated
| @@ -15,6 +15,7 @@ package tikv | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "github.com/pingcap/tidb/config" | |||
There was a problem hiding this comment.
put this package into the package block of the third-part packages
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
zz-jason
added
type/enhancement
zz-jason
added
status/LGT2
|
/run-all-tests |
jackysp
reviewed
Nov 7, 2018
|
PTAL @tiancaiamao |
|
@jackysp In this PR it's user's responsibility to ensure maxTxnTime is less than gc_life_time. There may be a better solution, but it will take some time to get it done. |
|
CI failed.. I'm not sure if that's caused by my chagnes |
|
/run-integration-ddl-test |
|
@tiancaiamao PTAL |
|
May this PR merge? @jackysp |
|
Hold on. PTAL @tiancaiamao . |
|
LGTM |
tiancaiamao
approved these changes
Nov 12, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 12, 2018
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
May 15, 2019
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What problem does this PR solve?
Sometimes in an olap senario, an
insert into selectstatement may take too long time to finish. Then themaxTxnTimeUse(590 seconds) may easily be exceeded. It's better to make it configurable.The
maxTxnTimeUseis required because we don't want the transaction be broken by GC. That's why we recommend users not to set the gc_life_time less than 10m. However we didn't really check if the gc_life_time was set too short. In this PR, I still didn't check it.What is changed and how it works?
This PR adds a field
max-txn-time-useto the config file, tikv-client` section. Then in 2pc.go use the config value instead of a constant.Check List
Tests
Code changes
Side effects
Related changes