Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: change default charset and collation from 'utf8 utf8_bin' to 'utf8mb4 utf8mb4_bin' (#7965) #8590

Merged
merged 10 commits into from Dec 6, 2018

Conversation

Projects
None yet
5 participants
@winkyao
Copy link
Member

commented Dec 6, 2018

What problem does this PR solve?

cherry-pick from #7965


This change is Reviewable

Please merge pingcap/parser#68 first.

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

@zimulala
Copy link
Member

left a comment

LGTM

@ciscoxll
Copy link
Contributor

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added status/LGT3 and removed status/LGT1 labels Dec 6, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

ci will be fixed after pingcap/parser#68 merged and pingcap/tidb-test#677 merged.

winkyao added some commits Dec 6, 2018

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 -tidb-test=pr/677

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

4 similar comments
@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/677 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-common-test -tidb-test=pr/678 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

/run-all-tests -tidb-test=pr/678 tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@winkyao winkyao merged commit d9d153e into pingcap:release-2.1 Dec 6, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:cherry-pick-2.1-charset branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.