Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: split tests to speed up tests #8612

Merged
merged 16 commits into from
Dec 13, 2018
Merged

ddl: split tests to speed up tests #8612

merged 16 commits into from
Dec 13, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 7, 2018 •
edited
Loading

What problem does this PR solve?

Split tests to speed up tests in ddl package.
Relate to pingcap/check#10

What is changed and how it works?

After merging pingcap/check#10, it supports for running tests in parallel.
So in this RP, we enable CustomParallelSuiteFlag and split tests.
gofail test can't be executed in parallel with other tests. so I put it to failttest.

Before this PR:
ok  	github.com/pingcap/tidb/ddl	62.052s	coverage: 82.1% of statements
After this PR:
ok  	github.com/pingcap/tidb/ddl	24.150s	coverage: 82.1% of statements

Check List

Tests

  • Unit test

This change is Reviewable

@zimulala zimulala added type/enhancement The issue or PR belongs to an enhancement. component/test labels Dec 7, 2018
@pingcap pingcap deleted a comment from zhouqiang-cl Dec 7, 2018
@pingcap pingcap deleted a comment from zhouqiang-cl Dec 7, 2018
@pingcap pingcap deleted a comment from zhouqiang-cl Dec 8, 2018
@pingcap pingcap deleted a comment from zhouqiang-cl Dec 8, 2018
@zhouqiang-cl
Copy link
Contributor

/run-common-test tidb-test=pr/681

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=pr/681

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@zimulala
Copy link
Contributor Author

zimulala commented Dec 11, 2018 •
edited
Loading

The reason circleci failed because the mod.go has replace.
The reason travis-ci failed because he command "./hack/check-tidy.sh" exited with 1.
I will remove it after pingcap/check#10 merge.

@zimulala zimulala added the priority/P1 The issue has P1 priority. label Dec 12, 2018
@zimulala
Copy link
Contributor Author

/run-all-tests

@zimulala
Copy link
Contributor Author

PTAL @winkyao @ciscoxll @crazycs520

crazycs520
crazycs520 reviewed Dec 12, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

crazycs520
crazycs520 reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ciscoxll
ciscoxll reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ciscoxll
ciscoxll reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimulala Please solve ci fail.

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 13, 2018
@zimulala
Copy link
Contributor Author

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@zimulala zimulala merged commit db2127a into pingcap:master Dec 13, 2018
@zimulala zimulala deleted the split-ut branch December 13, 2018 07:06
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@zimulala @iamzhoug37
ddl: split tests to speed up tests (pingcap#8612)
ec09dc0 
* ddl: add the db_partition_test
@zimulala zimulala mentioned this pull request Dec 13, 2018
Merged
@crazycs520 crazycs520 mentioned this pull request Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ciscoxll ciscoxll ciscoxll approved these changes

Assignees
No one assigned
Labels
component/test priority/P1 The issue has P1 priority. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @zhouqiang-cl @ciscoxll @crazycs520