Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix Wrong behavior of prepare && execute #9204

Merged
merged 4 commits into from
Feb 25, 2019
Merged

planner/core: fix Wrong behavior of prepare && execute #9204

merged 4 commits into from
Feb 25, 2019

Conversation

hhu-cc
Copy link
Contributor

@hhu-cc hhu-cc commented Jan 28, 2019

What problem does this PR solve?

Fix #8518

What is changed and how it works?

When prepare statement use table alias in group by clause ,
function extractTableList will change origin table name in prepare stage,
so fix it.

Tests

  • Unit test

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #9204 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #9204     +/-   ##
========================================
+ Coverage   67.19%   67.3%   +0.1%     
========================================
  Files         373     373             
  Lines       78450   78449      -1     
========================================
+ Hits        52715   52797     +82     
+ Misses      21013   20915     -98     
- Partials     4722    4737     +15
Impacted Files Coverage Δ
planner/core/logical_plan_builder.go 78.28% <ø> (+4.13%) ⬆️
executor/join.go 79.06% <0%> (-0.52%) ⬇️
planner/core/planbuilder.go 49.43% <0%> (+0.08%) ⬆️
planner/core/cacheable_checker.go 92.85% <0%> (+4.76%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a283a9...499ca9e. Read the comment docs.

@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Jan 28, 2019
@XuHuaiyu XuHuaiyu changed the title Fix Wrong behavior of prepare && execute planner/core: fix Wrong behavior of prepare && execute Jan 28, 2019
@XuHuaiyu XuHuaiyu added the contribution This PR is from a community contributor. label Jan 28, 2019
@XuHuaiyu
Copy link
Contributor

/run-all-tests

@eurekaka eurekaka added the sig/planner SIG: Planner label Jan 29, 2019
@hhu-cc
Copy link
Contributor Author

hhu-cc commented Jan 30, 2019

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jan 30, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2019
@zz-jason zz-jason merged commit f80e401 into pingcap:master Feb 25, 2019
@zz-jason
Copy link
Member

@hhxcc Thanks for your contribution, could you help us to cherry pick this commit to the release-2.1 branch?

@hhu-cc
Copy link
Contributor Author

hhu-cc commented Feb 26, 2019

@zz-jason ok, pr #9466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong behavior of prepare && execute
5 participants