Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: control Chunk size for StreamAgg&HashAgg #9512

Merged
merged 6 commits into from Mar 6, 2019

Conversation

@qw4990
Copy link
Contributor

qw4990 commented Feb 28, 2019

What problem does this PR solve?

Control the number of rows in chunks returned by TableReader & IndexReader & IndexLookup.
Following up #9452, this PR is a subtask of #9166.

What is changed and how it works?

  1. make StreamAgg and HashAgg support chunk size control.
  2. add some unit tests.

Check List

Tests

  • Unit test

@qw4990 qw4990 requested review from XuHuaiyu , lysu , zz-jason and winoros Feb 28, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #9512 into master will increase coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9512      +/-   ##
==========================================
+ Coverage   67.38%   67.39%   +0.01%     
==========================================
  Files         375      375              
  Lines       78783    78780       -3     
==========================================
+ Hits        53087    53096       +9     
+ Misses      20927    20918       -9     
+ Partials     4769     4766       -3
Impacted Files Coverage Δ
executor/aggregate.go 79.11% <81.25%> (+3.22%) ⬆️
ddl/delete_range.go 78.3% <0%> (-1.06%) ⬇️
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
executor/join.go 79.06% <0%> (-0.52%) ⬇️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccc4c1...f86e579. Read the comment docs.

Show resolved Hide resolved executor/aggregate.go Outdated

@qw4990 qw4990 force-pushed the qw4990:chunkSizeControl_StreamAgg/HashAgg branch from e96b277 to 866025f Mar 4, 2019

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Mar 4, 2019

@lysu lysu self-assigned this Mar 4, 2019

@qw4990 qw4990 requested review from lysu and removed request for lysu Mar 6, 2019

@zz-jason zz-jason requested review from eurekaka and lamxTyler Mar 6, 2019

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Mar 6, 2019

@lamxTyler

This comment has been minimized.

Copy link
Member

lamxTyler commented Mar 6, 2019

/run-all-tests

@qw4990 qw4990 force-pushed the qw4990:chunkSizeControl_StreamAgg/HashAgg branch from d45a319 to f86e579 Mar 6, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

qw4990 commented Mar 6, 2019

/run-all-tests

@qw4990 qw4990 merged commit 2f69a28 into pingcap:master Mar 6, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.