Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: support flush tidb plugin {name} in tidb-server (#9320) #9911

Merged
merged 6 commits into from
Mar 28, 2019
Merged

plugin: support flush tidb plugin {name} in tidb-server (#9320) #9911

merged 6 commits into from
Mar 28, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Mar 27, 2019

cherry-pick #9320 to 2.1

please review and merge pingcap/parser#262 first thx~


This change is Reviewable

@lysu
Copy link
Collaborator Author

lysu commented Mar 27, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@lysu lysu removed the status/DNM label Mar 27, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2019
@jackysp
Copy link
Member

jackysp commented Mar 28, 2019

PTAL @tiancaiamao

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@jackysp jackysp merged commit ca4d574 into pingcap:release-2.1 Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants