Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types,types/json: improve test coverage #9977

Merged
merged 12 commits into from
Apr 9, 2019
Merged

types,types/json: improve test coverage #9977

merged 12 commits into from
Apr 9, 2019

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Apr 1, 2019

What problem does this PR solve?

improve test coverage.

xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types$ GO111MODULE=on go test -cover | grep coverage
coverage: 85.0% of statements
xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types$ cd json/
xiekeyi@ubuntu:~/gopath/src/github.com/pingcap/tidb/types/json$ GO111MODULE=on go test -cover | grep coverage
coverage: 85.7% of statements

We have two PRs before:

But now, we need to improve it up to 85%, thus this PR be filed.

What is changed and how it works?

Add more tests to test functions.

Check List

Tests

  • Unit test
  • Integration test

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #9977 into master will decrease coverage by 0.4697%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9977        +/-   ##
================================================
- Coverage   78.0088%   77.5391%   -0.4698%     
================================================
  Files           404        403         -1     
  Lines         82024      81898       -126     
================================================
- Hits          63986      63503       -483     
- Misses        13332      13688       +356     
- Partials       4706       4707         +1

@xiekeyi98
Copy link
Contributor Author

/run-all-tests

1 similar comment
@xiekeyi98
Copy link
Contributor Author

/run-all-tests

@xiekeyi98
Copy link
Contributor Author

/run-all-tests

types/datum_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 9, 2019
@ngaut ngaut merged commit 1c21151 into pingcap:master Apr 9, 2019
@xiekeyi98 xiekeyi98 deleted the improveCov branch April 9, 2019 05:30
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants