tiflow 7.6: Bump TiDB dependency to v7.6.0 #10680
Conversation
Signed-off-by: kennytm <kennytm@gmail.com>
ti-chi-bot
bot
added
release-note-none
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/M
kennytm
added
the
do-not-merge/hold
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
use-tidb-v7.6.0
branch
from
632597d
to
8cd574b
Compare
|
@kennytm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -141,7 +167,12 @@ func (tr *Tracker) Init( | |||
| tableInfos: make(map[string]*DownstreamTableInfo), | |||
| } | |||
| // TODO: need to use upstream timezone to correctly check literal is in [1970, 2038] | |||
| se := executorContext{Context: mock.NewContext()} | |||
| seContext := mock.NewContext() | |||
| seContext.Store = &trackerMockStore{} | |||
There was a problem hiding this comment.
/cc @okJiang
can you check this change is expected? Can we move it into mock.NewContext()
There was a problem hiding this comment.
i think this should be moved into mock.NewContext() or make GetBDRMode() not requiring a valid txn but that would involve updating TiDB first 🥲
There was a problem hiding this comment.
I think it is unnecessary?
There was a problem hiding this comment.
But for v7.6, the pr is not merged.
There was a problem hiding this comment.
can you check this change is expected? Can we move it into mock.NewContext()
Yes
There was a problem hiding this comment.
I just see it targets to release-7.6. We don't need to maintain non LTS versions 😂 If there's an user request I prefer we cherry-pick pingcap/tidb#50939 to TiDB's release-7.6 branch
(pingcap/tidb#50537 is merged into v7.6 because on that day it's not released)
There was a problem hiding this comment.
if pingcap/tidb#50939 can be cherry-picked to 7.6 I'd prefer that ;)
kennytm
added
type/cherry-pick-for-release-7.6
What problem does this PR solve?
Issue Number: close #10679
What is changed and how it works?
Upgrade the go.mod version of tidb from pingcap/tidb@54d8a1416ab0 to pingcap/tidb@52794d985ba6 which is same as the tag v7.6.0.
This is required to bring in pingcap/tidb#50537, so that using a populated GCS sink won't cause DeadlineExceeded.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note