Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support fine-grained modify column and add column #50039

Merged
merged 75 commits into from
Jan 5, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jan 3, 2024

What problem does this PR solve?

Issue Number: close #48519

Problem Summary:

What changed and how does it work?

  • support modify column default value and comment
  • support add column nullable or not null with default value
  • change admin set bdr role local_only to admin unset bdr role

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

pkg/ddl/bdr.go Outdated Show resolved Hide resolved
pkg/executor/simple.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@okJiang
Copy link
Member Author

okJiang commented Jan 5, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 02:58:34.825536794 +0000 UTC m=+2398605.862763718: ☑️ agreed by tangenta.
  • 2024-01-05 03:15:07.753085146 +0000 UTC m=+2399598.790312074: ☑️ agreed by asddongmen.

@easonn7
Copy link

easonn7 commented Jan 5, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, easonn7, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit f5cb034 into pingcap:master Jan 5, 2024
16 of 20 checks passed
@okJiang okJiang deleted the bdr-bwlist-2 branch January 5, 2024 06:08
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
kennytm added a commit to kennytm/tiflow that referenced this pull request Feb 29, 2024
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm added a commit to kennytm/tiflow that referenced this pull request Feb 29, 2024
Signed-off-by: kennytm <kennytm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support executing DDL when cluster is in BDR mode
4 participants