Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock: add more mock to avoid dm ci failed #50939

Merged
merged 14 commits into from
Feb 17, 2024
Merged

mock: add more mock to avoid dm ci failed #50939

merged 14 commits into from
Feb 17, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Feb 2, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #50938

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
image
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Feb 2, 2024
GMHDBJD
GMHDBJD approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Merging #50939 (62ca57a) into master (5c95f3b) will increase coverage by 2.3967%.
Report is 32 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #50939        +/-   ##
================================================
+ Coverage   70.5732%   72.9699%   +2.3966%     
================================================
  Files          1467       1467                
  Lines        434825     445315     +10490     
================================================
+ Hits         306870     324946     +18076     
+ Misses       108699     100327      -8372     
- Partials      19256      20042       +786
Flag Coverage Δ
integration 50.5614% <0.0000%> (?)
unit 70.3009% <100.0000%> (-0.0775%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (-0.1820%) ⬇️
parser ∅ <ø> (∅)
br 50.6826% <ø> (+4.9172%) ⬆️

@okJiang
Copy link
Member Author

okJiang commented Feb 2, 2024

/retest

@lance6716
Copy link
Contributor

lance6716 commented Feb 4, 2024 •
edited
Loading

Seems the problem is in #50039 you changed the behaviour of TestModifyFromNullToNotNull. The unit test should always have the same behaviour as DM. Please revert it.

@ti-chi-bot ti-chi-bot bot removed the approved label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 10:21:41.410896138 +0000 UTC m=+1733742.975193838: ☑️ agreed by GMHDBJD.
  • 2024-02-04 08:37:41.419273138 +0000 UTC m=+86786.986043030: ☑️ agreed by lance6716.

@okJiang
Copy link
Member Author

okJiang commented Feb 4, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the approved label Feb 4, 2024
@okJiang
Copy link
Member Author

okJiang commented Feb 6, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit ba9b8a8 into pingcap:master Feb 17, 2024
23 checks passed
@lance6716 lance6716 mentioned this pull request Mar 1, 2024
Open
@lance6716 lance6716 mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@tangenta tangenta tangenta approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more mock to avoid dm ci failed
4 participants
@okJiang @lance6716 @tangenta @GMHDBJD