-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (#10466) #11242
Merged
ti-chi-bot
merged 2 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-10466-to-release-6.5
Jun 5, 2024
Merged
mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (#10466) #11242
ti-chi-bot
merged 2 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-10466-to-release-6.5
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
2 similar comments
/retest |
/retest |
hicqu
approved these changes
Jun 5, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Jun 12, 2024
commit c092599 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Wed Jun 12 00:26:59 2024 +0800 pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290) close pingcap#11211 commit 3426e46 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Tue Jun 11 19:40:29 2024 +0800 puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282) close pingcap#11219 commit 2a28078 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Tue Jun 11 16:40:37 2024 +0800 mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261) close pingcap#11213 commit 2425d54 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Tue Jun 11 16:40:30 2024 +0800 log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257) close pingcap#11254 commit 053cdaf Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Tue Jun 11 15:34:30 2024 +0800 cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287) close pingcap#11271 commit 327ba7b Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Tue Jun 11 11:42:00 2024 +0800 redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091) close pingcap#10124 commit d82ae89 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Mon Jun 10 22:28:29 2024 +0800 ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981) close pingcap#10890 commit f15bec9 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Fri Jun 7 16:16:28 2024 +0800 redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996) close pingcap#10900 commit ba50a0e Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Wed Jun 5 19:58:26 2024 +0800 test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037) close pingcap#11015 commit 94b9897 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Wed Jun 5 17:08:56 2024 +0800 mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946) close pingcap#10931 commit a912d33 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Wed Jun 5 10:49:25 2024 +0800 mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242) close pingcap#11241 commit 6277d9a Author: dongmen <20351731+asddongmen@users.noreply.github.com> Date: Wed May 29 20:13:22 2024 +0800 kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184) close pingcap#11073 commit 54e93ed Author: dongmen <20351731+asddongmen@users.noreply.github.com> Date: Wed May 29 17:43:22 2024 +0800 syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162) close pingcap#10516 commit 0ba9329 Author: Ti Chi Robot <ti-community-prow-bot@tidb.io> Date: Wed May 29 09:07:21 2024 +0800 (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180) close pingcap#11096 Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10466
What problem does this PR solve?
Issue Number: close #11241
What is changed and how it works?
The original calculation of worker-busy-ratio may have certain deviation when the flush time is long (such as larger than hundreds of milliseconds). And the longer the flush time, the larger the deviation. The reason for the deviation is that when the flsuh time is long, the interval between each time we increase the worker busy ratio value clearly exceeds 1s, resulting in the growth rate of the worker-busy-ratio per second being less than actual rate.
Performance Test Result
We take a large workload on upstream to keep worker-busy-ratio as 100%, and compare the improvement of sink performance before and after optimization.
After Optimization -- 33339 rows/s (+14%). Before Optimization -- 29075 rows/s
After Optimization -- 20528 rows/s(+13%). Before Optimization -- 18129 rows/s
After Optimization -- 7273 rows/s(+20%). Before Optimization -- 6048 rows/s
New panel of worker busy ratio
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note