sink(cdc): fix internal retry algothrim #9530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot
bot
added
size/L
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
commented
Aug 10, 2023
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
needs-cherry-pick-release-6.5
|
/test verify |
asddongmen
reviewed
Aug 11, 2023
asddongmen
reviewed
Aug 11, 2023
asddongmen
reviewed
Aug 11, 2023
asddongmen
reviewed
Aug 11, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
asddongmen
approved these changes
Aug 14, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/test cdc-integration-mysql-test |
Signed-off-by: qupeng <qupeng@pingcap.com>
CharlesCheung96
approved these changes
Aug 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hicqu
removed
the
needs-cherry-pick-release-6.5
asddongmen
added
the
needs-cherry-pick-release-6.5
|
In response to a cherrypick label: new pull request created to branch |
|
/need-cherry-pick-release-6.5 |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hicqu
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 15, 2023
close pingcap#9518 Signed-off-by: qupeng <qupeng@pingcap.com>
3AceShowHand
pushed a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9518
What is changed and how it works?
Term Definition
Prior to this PR, if the
DDLSinkorDMLSinkreturned the same error continuously, theSinkManagerwould retry it for 30 minutes. If different errors occurred, theSinkManagerwould reset the retry time counter. Once the 30 minutes were up, the sink manager would report anUnretryableErrorto theownerand the changefeed would fail immediately. However, theSinkManagercouldn't accurately determine whether the error returned by theDDLSinkorDMLSinkwas the same error (It does not reset the retry time counter when correctly), leading to incorrectUnretryableErrorreports and unexpected changefeed failures.With this PR, if the
DDLSinkorDMLSinkreturns the same error continuously, theSinkManagerwill continue retrying indefinitely but will report a warning to theowner. Since theownerhas a broader view of the changefeed, it can determine if the error reported by thesinkManageris the same error. This PR takes the checkpoint into account to make the decision. The underlying logic is simple: if the checkpoint advanced since the last error was reported, the subsequent error is not the same as the previous error. Thus, the retry time is reset to ensure that the subsequent error will be also retry for 30 minutes.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note