[BUG] The pin #7 should be inside list comprehension. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| ard = detect.MyBoard() | |||
|
|
|||
| display_pins = [ard.pins[i] for i in range(8, 14)] + [7] | |||
| display_pins = [ard.pins[i] for i in range(8, 14) + [7]] | |||
There was a problem hiding this comment.
display_pins = [ard.pins[i] for i in range(7, 14)]
Would range(7,14) work?
There was a problem hiding this comment.
Unfortunately no. This list is ordered according the segments in the display, ordered as: A, B, C, D, E, F, G and DP (pin 7 in the Garoa Shield). This list is then unpacked during SevenSegments object instantiation, which DP segment is the last parameter (optional):
seg_display = parts.led.SevenSegments(*display_pins)
|
Ok. Thanks @davivcgarcia |
Vido
added a commit
that referenced
this pull request
Nov 10, 2014
[BUG] The pin #7 should be inside list comprehension.
|
Thanks @davivcgarcia and @Vido! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After code refactoring, the pin number related to the DP segment was left outside the list comprehension call, adding the integer 7 instead of the pin ard.pin[7] object. This bug was not affecting the example because DP (pin 7) was not being used.