Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit SSL Protocol selection #22

Closed
GoogleCodeExporter opened this issue Feb 9, 2016 · 3 comments
Closed

Limit SSL Protocol selection #22

GoogleCodeExporter opened this issue Feb 9, 2016 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Qt only allows setting the allowed SSL protocol to Any (SSLv3, SSLv2,
TLSv1), SSLv3, or TLSv1, but not just SSLv3 and TLSv1.  Some https
implementations use TLSv1 and some use SSLv3, so support for both is
required.  SSLv2, however, has security issues.  Omapd as of revision 58
currently accepts any protocol.

Original issue reported on code.google.com by smat...@gmail.com on 6 Apr 2010 at 4:33

@GoogleCodeExporter
Copy link
Author

What about making the supported SSL protocol a configuration option?
At the moment we set the SSL protocol to QSsl::AnyProtocol (cmlserver.cpp line 
148)
If we did not set the protocol explicitly the class defaults to QSsl::SslV3 . 
TLSv1 support within the class is exclusive - with respect to the others.
So what about making  TLSv1 either a cmdline option or configuration file 
option ?
That would enable support for the secure protocols and remove support for SSLv2.

Original comment by darren.l...@gmail.com on 13 Jul 2010 at 6:59

@GoogleCodeExporter
Copy link
Author

r73 has commits that make the protocol selectable from the omapd.conf file.
This is the best that I could think of without modifying how the QSslSocket 
code itself.

Original comment by darren.l...@gmail.com on 14 Jul 2010 at 12:01

@GoogleCodeExporter
Copy link
Author

omapd can now reject SSLv2 connections, but only does so by closing the 
connection once it has been made.  This is a limitation in Qt.

Original comment by smat...@gmail.com on 25 Sep 2011 at 8:59

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant