Add singleLine config option
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 590866056
💛 - Coveralls |
|
Is this meant to include all of the work done in #125? If so, please see my comment in the PR for instructions on how to start your branch so that the original author is credited for their work. |
LucasPickering
force-pushed
the
issue-97-single-line
branch
from
4b9bf33
to
a6c702b
Compare
Sorry about that. I just pushed to include their commit. I had to make some changes to the test to match my implementation but the structure of them is the same. |
jsumners
reviewed
Feb 24, 2021
LucasPickering
force-pushed
the
issue-97-single-line
branch
from
a6c702b
to
ae9beee
Compare
LucasPickering
force-pushed
the
issue-97-single-line
branch
from
ae9beee
to
980205e
Compare
jsumners
reviewed
Feb 26, 2021
LucasPickering
force-pushed
the
issue-97-single-line
branch
from
9c3260a
to
28a8996
Compare
Thanks for bearing with me on this. I rebased master + squashed, is there anything else I need to do before this can be merged? |
|
Yay, thank you so much for implementing this ❤️ |
LucasPickering
referenced
this pull request
in MarkForged/pino-pretty
Mar 5, 2021
A bug in #158 left a trailing space on lines that had no extra log fields with singleLine=true. This commit fixes that, and updates a test accordingly.
mcollina
pushed a commit
that referenced
this pull request
Mar 8, 2021
A bug in #158 left a trailing space on lines that had no extra log fields with singleLine=true. This commit fixes that, and updates a test accordingly.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
singleLineconfig option. When enabled, all unrecognized non-error fields will be printed on the same line as the main log message, as a simple JSON string. Error messages are still printed like normal, on a new line.The implementation for this is very rough. I wanted to get feedback on the design/behavior before I spent any time polishing the code. I also haven't updated any docs yet. The tests should provide all the examples/behavior definitions needed though.
This builds off of #125 and hopefully fixes #97.
Remaining work: