-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 multiline option #125
🚧 multiline option #125
Conversation
})) | ||
log.info({ msg: { b: { c: 'd' } }, extra: { foo: 'bar', number: 42 } }) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing that both the msg
and the extra data are logged inline instead of separated by newlines
We could also do a Or if you prefer the single line altogether, we can just make it the default without adding any option and release that as v5. I think we'll be able to remove quite some code. |
What about error messages? |
I think the stack should be on multiple lines. |
Can you tell me what way you want me to implement this?
|
Can I see what the result would look like for a big object? The "deepObject" fixture in the Pino benchmarks should suffice. |
@gr2m Any update on this? I'd be happy to work on implementation if you don't have time. |
no update. Yes, please, it's all yours! Happy to review your own pull request. Sorry that I still didn't find the time to finish this |
@LucasPickering please see #144 (comment) for instructions on how to include @gr2m's work if you are not familiar. |
Close with no activity. |
I've added failing test so we can discuss the way we want to address #97
I would suggest to add a
multiline
option so we can release this as a feature release, then change the default fromfalse
totrue
as part of v5eventually fixes #97