Add option for single-line logging of extra attributes

[zdila]

Logs with multiple extra attributes now take too many lines. Personally I prefer buynan formatting.

Example:

logger.info({ id: 22246537, type: 'story' }, 'Saving item.');

Current output with pino-pretty -t -i hostname,pid:

[2020-02-05 13:32:31.528 +0000] INFO : Saving item.
    id: 22246537
    type: "story"

Preferred output:

[2020-02-05 13:32:31.528 +0000] INFO : Saving item. { id: 22246537, type: "story" }

[mcollina]

would you like to send a PR? Il 5 feb 2020, 14:36 +0100, Martin Ždila <notifications@github.com>, ha scritto:

…

Logs with multiple extra attributes now take too many lines. Personally prefer buynan formatting. Example: logger.info({ id: 22246537, type: 'story' }, 'Saving item.'); Current output with pino-pretty -t -i hostname,pid: [2020-02-05 13:32:31.528 +0000] INFO : Saving item. id: 22246537 type: "story" Preferred output: [2020-02-05 13:32:31.528 +0000] INFO : Saving item. { id: 22246537, type: "story" } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[zdila]

Thanks. I can try.

[ritlew]

Can someone point me to some files/functions to get started on this feature?

[jsumners]

pino-pretty/index.js

Lines 122 to 146 in 852fdf7

	if (line.length > 0) {
	line += EOL
	}
	if (log.type === 'Error' && log.stack) {
	const prettifiedErrorLog = prettifyErrorLog({
	log,
	errorLikeKeys: errorLikeObjectKeys,
	errorProperties: errorProps,
	ident: IDENT,
	eol: EOL
	})
	line += prettifiedErrorLog
	} else {
	const skipKeys = [messageKey, levelKey, timestampKey].filter(key => typeof log[key] === 'string' || typeof log[key] === 'number')
	const prettifiedObject = prettifyObject({
	input: log,
	skipKeys,
	customPrettifiers,
	errorLikeKeys: errorLikeObjectKeys,
	eol: EOL,
	ident: IDENT
	})
	line += prettifiedObject
	}

[gr2m]

Is anyone working on this? I'd prefer the inline attributes, too! I can work on a PR, but wonder if there is some prior work on this?

[jsumners]

It does not seem anyone is working on this.

[gr2m]

I'm looking into it today

[gr2m]

@mcollina would you like me to add an option or just change the default behavior?

I think this change would be a breaking change, but I do prefer the single line output. Maybe we can introduce a new option multiline and set it to true by default for the current version (4.x) to retain the current behavior, then with 5.0.0 we would change the default for that option to false?

[mcollina]

Let's add the option and then discuss the default. I kind of prefer single-line as well, but it's semver major.