Fix cloning errors #286
Fix cloning errors #286
Conversation
Pull Request Test Coverage Report for Build 1587052890
💛 - Coveralls |
| @@ -1,6 +1,6 @@ | |||
| 'use strict' | |||
|
|
|||
| const clone = require('rfdc')({ circles: true }) | |||
There was a problem hiding this comment.
Are there any other methods for resolving the issue at hand? This replacement module has not been updated in quite some time, has a long open dependabot PR, and planttheidea/fast-copy#39 (comment)
There was a problem hiding this comment.
I checked every library with deep cloning and a minimal user base but I couldn't find any other library that can clone errors and would pass every test
There was a problem hiding this comment.
Is there any other way, within this code base, outside of a cloning module?
There was a problem hiding this comment.
None that I can think of unfortunately
There was a problem hiding this comment.
I'd like to hear from @davidmarkclements on this.
There was a problem hiding this comment.
@davidmarkclements ping?
There was a problem hiding this comment.
If I get a fix on rdfc, I'd be very happy to.
There was a problem hiding this comment.
which fix are you talking about?
There was a problem hiding this comment.
add support to rdfc to clone errors.
| @@ -564,12 +564,12 @@ function deleteLogProperty (log, property) { | |||
| * Filter a log object by removing any ignored keys. | |||
| * | |||
| * @param {object} log The log object to be modified. | |||
| * @param {string} ignoreKeys An array of strings identifying the properties to be removed. | |||
| * @param {Set<string> | Array<string>} ignoreKeys An array of strings identifying the properties to be removed. | |||
There was a problem hiding this comment.
| * @param {Set<string> | Array<string>} ignoreKeys An array of strings identifying the properties to be removed. | |
| * @param {string[]} ignoreKeys An array of strings identifying the properties to be removed. |
Fixes #260