Dropping args and replacing by minimist

[marcelfranca]

Fix issue #336

[jsumners]

I suspect there is more work that needs to be done in addition to changing the package.json.

[marcelfranca]

I might understood wrong but I was told to create a DRAFT as soon as I started to work to show that someone is working on it.

[simoneb]

@jsumners we are used to opening Draft PRs early on, no need to request changes on a Draft PR anyway since it can't be merged.

@marcelfranca you mentioned you're having troubles migrating some options from args to minimist, shout if you need any input so the people contributing to this repo can help out.

[jsumners]

In the future, please start work from a feature branch. See https://jrfom.com/posts/2017/03/08/a-primer-on-contributing-to-projects-with-git/#create-a-feature-branch

[jsumners]

This PR results in a loss of CLI help. Prior to this PR, one could pino-pretty --help and get descriptions of each allowed option along with some helpful examples. With this PR, pino-pretty --help just hangs waiting for input.

If minimist does not support this feature, and newer versions of args have not resolved the problem prompting issue #336, then I recommend looking at sade instead -- https://github.com/lukeed/sade#single-command-mode

[marcelfranca]

Yes, minimist does support, I'll add it.

Also, I created a PR for args that fixes the problem we had with it, but no updates so far.

Here is the link for the PR:
leo/args#166

[jsumners]

Also, I created a PR for args that fixes the problem we had with it, but no updates so far.

Here is the link for the PR: leo/args#166

You should add a test to that PR that fails prior to your fix.

[mcollina]

lgtm

[jsumners]

I don't like moving the help text out to a text file:

1. It will get out of sync
2. The examples are no longer contextual, they are only available in the root --help

But I'm not going to block this.

Not blocking

[simoneb]

I don't like moving the help text out to a text file:

1. It will get out of sync
2. The examples are no longer contextual, they are only available in the root --help

But I'm not going to block this.

I understand that and I can agree. Unfortunately that's the only option with minimist (afaik), also used in https://github.com/fastify/fastify-cli/

[coveralls]

Pull Request Test Coverage Report for Build 2542653509

• 0 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 2542630725:	0.0%
Covered Lines:	383
Relevant Lines:	383

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 2542653509

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 2542630725:	0.0%
Covered Lines:	383
Relevant Lines:	383

---

💛 - Coveralls