Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating for v9 #140

Closed
ghost opened this issue Jan 22, 2024 · 2 comments · Fixed by #141
Closed

Updating for v9 #140

ghost opened this issue Jan 22, 2024 · 2 comments · Fixed by #141

Comments

@ghost
Copy link

ghost commented Jan 22, 2024

Hi, I would like to migrate the tests from tap to node:test
@jsumners
Copy link
Member

Thank you for volunteering. In the future, please follow the instructions provided in pinojs/pino#1762 when volunteering to take on the v9 prep work for a module.

A next branch already exists for this repo.

@jsumners jsumners added this to v9 Work Jan 22, 2024
@github-project-automation github-project-automation bot moved this to Todo in v9 Work Jan 22, 2024
@ghost ghost mentioned this issue Feb 11, 2024
Merged
@ghost
Copy link
Author

ghost commented Mar 9, 2024

Can be closed now. Completed as of #141

@github-project-automation github-project-automation bot moved this from Todo to Done in v9 Work Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v9 Work
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Port tests from tap to node:assert and node:test
2 participants
@mcollina @jsumners