Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch Client Plugin Contribution #5582

Closed
wants to merge 5 commits into from

Conversation

yin-bp
Copy link
Contributor

@yin-bp yin-bp commented May 9, 2019

Title: Elasticsearch Client Plugin Contribution

Link: https://github.com/bbossgroups/pinpoint/tree/elasticsearch-567/plugins/elasticsearch-bboss
Target: Elasticsearch Rest Client BBoss
Supported Version: pinpoint 1.9.0
Description: This agent plugin is worked with elasticsearch rest client BBoss,BBoss is a best Java Highlevel Rest client for ElasticSearch.

ServiceTypes: [9201, "ElasticsearchBBoss"],[9202, "ElasticsearchBBossExecutor"]
Annotations: [971, "es.args"],[972, "es.url"],[973, "es.dsl"],[974, "es.action"],[975, "es.responseHandle"],[976, "es.version"]

Configurations: List of configuration keys and description the plugin adds.

profiler.elasticsearchbboss.enabled=true //enable or disable this plugin, default true.
profiler.elasticsearchbboss.recordResult=false //record or disable record method return value ,default false.
profiler.elasticsearchbboss.recordArgs=true //record or disable record method args,default true.
profiler.elasticsearchbboss.recordDsl=true //record or disable record dsl,default true.
profiler.elasticsearchbboss.recordESVersion=true //record or disable record ES Version infomation,default true.
profiler.elasticsearchbboss.recordResponseHandlerClass=false //record or disable record response handle class ,default false.
profiler.elasticsearchbboss.maxDslSize=50000 //set the max length dsl script,over this size dsl will be substring.

@yin-bp
Copy link
Contributor Author

yin-bp commented May 9, 2019

[#5411] Add histogram for Alias #5551
@RoySRose

modify document
@RoySRose
Copy link
Contributor

Hello, @yin-bp

Before I take a look at the code.
May I ask you why commit [#4558] Fix SpanChunk handle of Collector is included in this PR?

Commits from other contributors will not be included if you try to Rebase instead of Merge.

@yin-bp
Copy link
Contributor Author

yin-bp commented May 13, 2019

Hello, @yin-bp

Before I take a look at the code.
May I ask you why commit [#4558] Fix SpanChunk handle of Collector is included in this PR?

Commits from other contributors will not be included if you try to Rebase instead of Merge.
@RoySRose
Sorry,I don't know the rule before. I'll submit another PR soon.
A new PR is #5596

@yin-bp yin-bp closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants