Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a need for SingleOutputProblem and MultiOutputProblem? #1372

Closed
ben18785 opened this issue Aug 3, 2021 · 1 comment
Closed

Is there a need for SingleOutputProblem and MultiOutputProblem? #1372

ben18785 opened this issue Aug 3, 2021 · 1 comment

Comments

@ben18785
Copy link
Collaborator

ben18785 commented Aug 3, 2021

Both methods take the same arguments. Indeed, looking at the two classes, they're both virtually identical.

They both use model.n_parameters() to check that the user has provided an object of which outputs the correct dimensions. By the same token, couldn't we just use model.n_outputs() in a single OutputProblem method to determine whether it's a single or multiple output problem internally (so a user doesn't have to specify this)?

@MichaelClerx
Copy link
Member

From a quick glance it seems the main difference is that single output problems return data of the shape (n_times,), rather than (n_times, n_outputs).
For sensitivities it's (n_times, n_parameters) instead of (n_times, n_outputs, n_parameters)

So it's purely for user convenience, I think, so that single-output users don't need to always work in the multi-output space with n_outputs=1.

Open for discussion :D

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants