Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in e2e tests can cause GitHub workflows to run for maximum duration #559

Closed
hasheddan opened this issue Jul 24, 2023 · 1 comment · Fixed by #567
Closed

Failures in e2e tests can cause GitHub workflows to run for maximum duration #559

hasheddan opened this issue Jul 24, 2023 · 1 comment · Fixed by #567
Assignees

Comments

@hasheddan
Copy link
Contributor

hasheddan commented Jul 24, 2023

What did you do?

I noticed in a recent e2e workflow run that it ran for 6 hours before ultimately being canceled. It appears this was due to an intermittent issue, but the failure caused the test to never end.

Screen Shot 2023-07-24 at 4 27 59 PM

What did you expect?

I expected a failing e2e test to run to completion.

Assigning myself here to hunt down the issue, but we should also likely reduce the max workflow run time.

@hasheddan hasheddan self-assigned this Jul 24, 2023
@daenney
Copy link
Member

daenney commented Jul 25, 2023

The workflows are synced from here: https://github.com/pion/.goassets/tree/master/ci/.github/workflows and the reusable ones in https://github.com/pion/.goassets/tree/master/.github/workflows. We should set timeouts on the flows there honestly. Most test runs, I think even for other things in the Pion org, are expected to run in 5-10min tops.

The e2e.yaml in this repo is unique to this repo, so you can set a timeout on that one directly by plonking a https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants