Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid webrtc/pkg/rtcerr dependency #6

Closed
backkem opened this issue Apr 1, 2019 · 2 comments
Closed

Avoid webrtc/pkg/rtcerr dependency #6

backkem opened this issue Apr 1, 2019 · 2 comments

Comments

@backkem
Copy link
Member

backkem commented Apr 1, 2019

Summary

Avoid webrtc/pkg/rtcerr dependency

Motivation

It doesn't make sense for pions/ice to depend on pions/webrtc.

Describe alternatives you've considered

We can either:

  • Move rtcerr to it's own repo.
  • Avoid using rtcerr in package ICE. This seems more correct but will probably require translation of the errors in pions/webrtc.
@mjmac
Copy link
Contributor

mjmac commented Apr 1, 2019 •
edited
Loading

I concur that the dependency is wrong, and that option 2 seems most correct.

@Sean-Der
Copy link
Member

Fixed with af1bcf6

I don't know if I fixed it completely gracefully but it had to be done during pions -> pion move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjmac @Sean-Der @backkem