Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected pair is not accurate #82

Open
enobufs opened this issue Jul 17, 2019 · 0 comments
Open

Selected pair is not accurate #82

enobufs opened this issue Jul 17, 2019 · 0 comments

Comments

@enobufs
Copy link
Member

enobufs commented Jul 17, 2019

Tested with v0.5.2

One of the tests below revealed that the selected pair (one of the two endpoints) sets does not seem to be correct:

Run.

PION_LOG_TRACE=all go test -v -run TestConnectivityVNet/Symmetric_NATs

One end reports correctly:

ice TRACE: 09:52:48.744710 agent.go:474: Set selected candidate pair: prio 72057593450725376 (local, prio 16777215) relay 1.2.3.4:5495 related 0.0.0.0:5237 <-> prflx 28.1.1.1:49157 related :0 (remote, prio 1862270975)

But the other end says:

ice TRACE: 09:52:48.745427 agent.go:474: Set selected candidate pair: prio 72057593987596287 (local, prio 2130706431) host 10.2.0.1:5300 <-> relay 1.2.3.4:5495 related 0.0.0.0:5237 (remote, prio 16777215)

Local host candidate is not the one succeeded. It should be prflx candidate.

This is probably due to the fact that the ice agent is not checking the mapped-address of received STUN binding response to identify the corresponding local candidate, and incorrectly marking the 'host' candidate as seen connectivity.

This does not affect any connectivity, however, it would be confusing during the debugging or a diagnosis (stats, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants